<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507">bug 108507</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=108507#c10">comment #10</a>)
<span class="quote">> This broke "run-webkit-tests --pixel" behavior, at least on Mac. How it is
> supposed to work is that --pixel has no effect on tests that call
> testRunner.dumpAsText() or testRunner.dumpAsText(false). But now,
> WebKitTestRunner dumps pixels for these, so all text-only tests fail when
> run in this mode.
>
> This breaks an important testing scenario, so I'll roll out for now.</span >
Oh, I'm sorry about this, I got confused with all the shouldDumpPixels in TestInvocation, TestRunner, InjectedBundle and InjectedBundlePage. Now that I understand it, I'm going to split the patch, first to avoid creating snapshots in the web process that will be ignored, and then the one to fix the printing snapshots.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>