[Webkit-unassigned] [Bug 149505] Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 25 20:06:56 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=149505

--- Comment #7 from João Oliveira <hello at jxs.pt> ---
Comment on attachment 261931
  --> https://bugs.webkit.org/attachment.cgi?id=261931
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261931&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:918
>> +        this._findBanner.numberOfResults = numberOfResults;
> 
> You have a findBanner parameter for this function.  Is there a reason that you don't use it?  If so, why not remove the parameter?

you are right, no need to use it on this function, going to remove it

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150926/b833335a/attachment.html>


More information about the webkit-unassigned mailing list