[Webkit-unassigned] [Bug 149505] Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149505

--- Comment #6 from Devin Rousso <dcrousso+webkit at gmail.com> ---
Comment on attachment 261931
  --> https://bugs.webkit.org/attachment.cgi?id=261931
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261931&action=review

> Source/WebInspectorUI/UserInterface/Main.html:85
> +    <link rel="stylesheet" href="Views/ConsoleFindBanner.css">

We organize CSS files by alphabetical order.  Please move this to its appropriate place.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:918
> +        this._findBanner.numberOfResults = numberOfResults;

You have a findBanner parameter for this function.  Is there a reason that you don't use it?  If so, why not remove the parameter?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150926/995d1d7d/attachment-0001.html>