[Webkit-unassigned] [Bug 149505] Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149505

--- Comment #3 from Devin Rousso <dcrousso+webkit at gmail.com> ---
Comment on attachment 261915
  --> https://bugs.webkit.org/attachment.cgi?id=261915
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261915&action=review

> Source/WebInspectorUI/UserInterface/Views/ConsoleFindBanner.css:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.

2013?

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:34
> +        this._element.classList.add(className);

I would recommend adding an if statement/fallback in case className is ever falsy.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:73
> +            this._doneButton = document.createElement("button");

We like to name our DOM element variables with *Element.  Also, this variable isn't used outside of this loop, so it's really not necessary to save it:
let doneButtonElement = ...

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:202
> +        this._delegate.searchBarWantsToLoseFocus();

You should add a check here to ensure that the delegate exists and has a function called searchBarWantsToLoseFocus.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:205
> +

NIT: remove extra newlines.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:896
> +        var numberOfResults = 0;

We are using "let" instead of "var" now.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:904
> +                numberOfResults ++;

NIT: remove extra space.
numberOfResults++;

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:924
> +        this._searchBar.numberOfResults =  numberOfResults;

NIT: remove extra space.
= numberOfResults;

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150925/f484b039/attachment.html>