<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
href="https://bugs.webkit.org/show_bug.cgi?id=149505#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
href="https://bugs.webkit.org/show_bug.cgi?id=149505">bug 149505</a>
from <span class="vcard"><a class="email" href="mailto:dcrousso+webkit@gmail.com" title="Devin Rousso <dcrousso+webkit@gmail.com>"> <span class="fn">Devin Rousso</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261915&action=diff" name="attach_261915" title="patch">attachment 261915</a> <a href="attachment.cgi?id=261915&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261915&action=review">https://bugs.webkit.org/attachment.cgi?id=261915&action=review</a>
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/ConsoleFindBanner.css:2
> + * Copyright (C) 2013 Apple Inc. All rights reserved.</span >
2013?
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:34
> + this._element.classList.add(className);</span >
I would recommend adding an if statement/fallback in case className is ever falsy.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:73
> + this._doneButton = document.createElement("button");</span >
We like to name our DOM element variables with *Element. Also, this variable isn't used outside of this loop, so it's really not necessary to save it:
let doneButtonElement = ...
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:202
> + this._delegate.searchBarWantsToLoseFocus();</span >
You should add a check here to ensure that the delegate exists and has a function called searchBarWantsToLoseFocus.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:205
> +</span >
NIT: remove extra newlines.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:896
> + var numberOfResults = 0;</span >
We are using "let" instead of "var" now.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:904
> + numberOfResults ++;</span >
NIT: remove extra space.
numberOfResults++;
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:924
> + this._searchBar.numberOfResults = numberOfResults;</span >
NIT: remove extra space.
= numberOfResults;</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>