[Webkit-unassigned] [Bug 149435] GCThreadSharedData is just a bad way of saying Heap

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149435

--- Comment #2 from Filip Pizlo <fpizlo at apple.com> ---
(In reply to comment #1)
> (In reply to comment #0)
> > The GCThreadSharedData object maps 1-to-1 to a Heap. Its existence adds
> > nothing useful.
> 
> I wouldn't say that it adds nothing.  It does encapsulate the GC thread
> management code, and I think there is value in modularizing the code as
> opposed to having it all in one giant heap class.  That said, if it is
> adding complexity that is preventing your concurrent GC work, I won't object
> to its removal (especially since it may not be the best abstraction for
> breaking down the heap when you're done with the concurrent GC design).

It's basically a struct since everyone who deals with it is a friend and accesses its members directly.  So, it's a purely harmful class - it provides no encapsulation but it does mean more code for accessing its data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150922/bdb158a6/attachment.html>