<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - GCThreadSharedData is just a bad way of saying Heap"
href="https://bugs.webkit.org/show_bug.cgi?id=149435#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - GCThreadSharedData is just a bad way of saying Heap"
href="https://bugs.webkit.org/show_bug.cgi?id=149435">bug 149435</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=149435#c1">comment #1</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=149435#c0">comment #0</a>)
> > The GCThreadSharedData object maps 1-to-1 to a Heap. Its existence adds
> > nothing useful.
>
> I wouldn't say that it adds nothing. It does encapsulate the GC thread
> management code, and I think there is value in modularizing the code as
> opposed to having it all in one giant heap class. That said, if it is
> adding complexity that is preventing your concurrent GC work, I won't object
> to its removal (especially since it may not be the best abstraction for
> breaking down the heap when you're done with the concurrent GC design).</span >
It's basically a struct since everyone who deals with it is a friend and accesses its members directly. So, it's a purely harmful class - it provides no encapsulation but it does mean more code for accessing its data.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>