[Webkit-unassigned] [Bug 149286] De-template ContainerNodeAlgorithms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149286

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 261425
  --> https://bugs.webkit.org/attachment.cgi?id=261425
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261425&action=review

> Source/WebCore/html/track/WebVTTParser.cpp:544
> +        auto child = Text::create(document, m_token.characters());
> +        m_currentNode->parserAppendChild(WTF::move(child));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1031
> +    auto newNode = CDATASection::create(m_currentNode->document(), toString(s, len));
> +    m_currentNode->parserAppendChild(WTF::move(newNode));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.

> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1047
> +    auto newNode = Comment::create(m_currentNode->document(), toString(s));
> +    m_currentNode->parserAppendChild(WTF::move(newNode));

If we did it on one line without the local variable then we wouldn’t need to call WTF::move.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150919/09b5333b/attachment.html>