<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - De-template ContainerNodeAlgorithms"
href="https://bugs.webkit.org/show_bug.cgi?id=149286#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - De-template ContainerNodeAlgorithms"
href="https://bugs.webkit.org/show_bug.cgi?id=149286">bug 149286</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261425&action=diff" name="attach_261425" title="patch">attachment 261425</a> <a href="attachment.cgi?id=261425&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261425&action=review">https://bugs.webkit.org/attachment.cgi?id=261425&action=review</a>
<span class="quote">> Source/WebCore/html/track/WebVTTParser.cpp:544
> + auto child = Text::create(document, m_token.characters());
> + m_currentNode->parserAppendChild(WTF::move(child));</span >
If we did it on one line without the local variable then we wouldn’t need to call WTF::move.
<span class="quote">> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1031
> + auto newNode = CDATASection::create(m_currentNode->document(), toString(s, len));
> + m_currentNode->parserAppendChild(WTF::move(newNode));</span >
If we did it on one line without the local variable then we wouldn’t need to call WTF::move.
<span class="quote">> Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:1047
> + auto newNode = Comment::create(m_currentNode->document(), toString(s));
> + m_currentNode->parserAppendChild(WTF::move(newNode));</span >
If we did it on one line without the local variable then we wouldn’t need to call WTF::move.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>