[Webkit-unassigned] [Bug 149340] Implement type conversion instructions in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149340

--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 261498
  --> https://bugs.webkit.org/attachment.cgi?id=261498
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261498&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:378
> +    int buildConvertType(int, WASMExpressionType fromType, WASMExpressionType toType, WASMTypeConversion conversion)

Shouldn't the first argument and return type be of type ContextExpression?

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:382
> +            load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT0);

Everything looks fine, but I'm unfamiliar with this expression of "temporaryAddress(m_tempStackTop - 1)".  Just to make sure there is no bug here, can you explain what it means?  Specifically,
1. why is it called a "temporary" address?
2. why is it referring to "m_tempStackTop - 1"?  My interpretation is that you're operating on the operand at the top of the stack.  Hence, my naive expectation is that you would want "m_tempStackTop" instead?

Can you please clarify?  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150918/af6e5cfd/attachment-0001.html>