<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement type conversion instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149340#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement type conversion instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=149340">bug 149340</a>
from <span class="vcard"><a class="email" href="mailto:mark.lam@apple.com" title="Mark Lam <mark.lam@apple.com>"> <span class="fn">Mark Lam</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261498&action=diff" name="attach_261498" title="Patch">attachment 261498</a> <a href="attachment.cgi?id=261498&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261498&action=review">https://bugs.webkit.org/attachment.cgi?id=261498&action=review</a>
<span class="quote">> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:378
> + int buildConvertType(int, WASMExpressionType fromType, WASMExpressionType toType, WASMTypeConversion conversion)</span >
Shouldn't the first argument and return type be of type ContextExpression?
<span class="quote">> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:382
> + load32(temporaryAddress(m_tempStackTop - 1), GPRInfo::regT0);</span >
Everything looks fine, but I'm unfamiliar with this expression of "temporaryAddress(m_tempStackTop - 1)". Just to make sure there is no bug here, can you explain what it means? Specifically,
1. why is it called a "temporary" address?
2. why is it referring to "m_tempStackTop - 1"? My interpretation is that you're operating on the operand at the top of the stack. Hence, my naive expectation is that you would want "m_tempStackTop" instead?
Can you please clarify? Thanks.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>