[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

--- Comment #22 from Zach Li <zacharyli323 at gmail.com> ---
Comment on attachment 261233
  --> https://bugs.webkit.org/attachment.cgi?id=261233
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=261233&action=review

>> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:96
>> +        if (CFGetTypeID(item) == CFArrayGetTypeID() && CFArrayGetCount((CFArrayRef)item) == 2) {
> 
> Can use dynamic_cf_cast here.

I will change that.

>> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:64
>> +        [items addObject:[NSArray arrayWithObjects:searchItem.first, [[NSNumber alloc] initWithDouble:searchItem.second], nil]];
> 
> I think you should use NSDate for the times instead.

Yup, I should, as using NSDate is consistent with other user defaults.

>> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:77
>> +            searchItems.append(std::make_pair((String)item[0], ((NSNumber*)item[1]).doubleValue));
> 
> You can use dynamic_objc_cast here.

I will change that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150917/48a48f3f/attachment-0001.html>