<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388#c22">Comment # 22</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388">bug 148388</a>
from <span class="vcard"><a class="email" href="mailto:zacharyli323@gmail.com" title="Zach Li <zacharyli323@gmail.com>"> <span class="fn">Zach Li</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=261233&action=diff" name="attach_261233" title="Patch v2">attachment 261233</a> <a href="attachment.cgi?id=261233&action=edit" title="Patch v2">[details]</a></span>
Patch v2
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261233&action=review">https://bugs.webkit.org/attachment.cgi?id=261233&action=review</a>
<span class="quote">>> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:96
>> + if (CFGetTypeID(item) == CFArrayGetTypeID() && CFArrayGetCount((CFArrayRef)item) == 2) {
>
> Can use dynamic_cf_cast here.</span >
I will change that.
<span class="quote">>> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:64
>> + [items addObject:[NSArray arrayWithObjects:searchItem.first, [[NSNumber alloc] initWithDouble:searchItem.second], nil]];
>
> I think you should use NSDate for the times instead.</span >
Yup, I should, as using NSDate is consistent with other user defaults.
<span class="quote">>> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:77
>> + searchItems.append(std::make_pair((String)item[0], ((NSNumber*)item[1]).doubleValue));
>
> You can use dynamic_objc_cast here.</span >
I will change that.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>