[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

--- Comment #21 from Jessie Berlin <jberlin at webkit.org> ---
Comment on attachment 261397
  --> https://bugs.webkit.org/attachment.cgi?id=261397
Patch v3

View in context: https://bugs.webkit.org/attachment.cgi?id=261397&action=review

These new searches that have a time associated with them should probably be put in a new location (aka with a new preference key). Clients of WebKit will probably need to do the migration from the old preference key to the new one - unless I am missing some facility in WebKit to do that directly. Anders?

> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:106
> +            searchItems.append(RecentSearchItem((String)(CFStringRef)CFArrayGetValueAtIndex((CFArrayRef)item, 0), searchTime));

As Anders pointed out, this will probably break older clients.

> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:86
> +            searchItems.append(RecentSearchItem((String)item, system_clock::time_point::min()));

As Anders pointed out, this will break older clients. You are storing an array or arrays where they are expecting an array of strings.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150917/1d58de6e/attachment.html>