<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388">bug 148388</a>
from <span class="vcard"><a class="email" href="mailto:jberlin@webkit.org" title="Jessie Berlin <jberlin@webkit.org>"> <span class="fn">Jessie Berlin</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261397&action=diff" name="attach_261397" title="Patch v3">attachment 261397</a> <a href="attachment.cgi?id=261397&action=edit" title="Patch v3">[details]</a></span>
Patch v3
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261397&action=review">https://bugs.webkit.org/attachment.cgi?id=261397&action=review</a>
These new searches that have a time associated with them should probably be put in a new location (aka with a new preference key). Clients of WebKit will probably need to do the migration from the old preference key to the new one - unless I am missing some facility in WebKit to do that directly. Anders?
<span class="quote">> Source/WebCore/platform/win/SearchPopupMenuWin.cpp:106
> + searchItems.append(RecentSearchItem((String)(CFStringRef)CFArrayGetValueAtIndex((CFArrayRef)item, 0), searchTime));</span >
As Anders pointed out, this will probably break older clients.
<span class="quote">> Source/WebKit/mac/WebCoreSupport/SearchPopupMenuMac.mm:86
> + searchItems.append(RecentSearchItem((String)item, system_clock::time_point::min()));</span >
As Anders pointed out, this will break older clients. You are storing an array or arrays where they are expecting an array of strings.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>