[Webkit-unassigned] [Bug 108507] printing does not use minimum page zoom factor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=108507

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #6)
> Comment on attachment 260361 [details]
> Try to fix CG build
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260361&action=review
> 
> Looks OK to me.

Thanks for the review.

> > Source/WebCore/page/PrintContext.cpp:320
> > +int PrintContext::numberOfPages(Frame* frame, const FloatSize& pageSizeInPixels)
> 
> Should take a Frame&. The caller is the one that checks for null.

Will change that and the all the callers.

> > Source/WebCore/page/PrintContext.cpp:329
> > +void PrintContext::spoolAllPagesWithBoundaries(Frame* frame, GraphicsContext& graphicsContext, const FloatSize& pageSizeInPixels)
> 
> Should take a Frame&. The caller is the one that checks for null.

Same here.

> > Source/WebCore/page/PrintContext.cpp:347
> > +#if PLATFORM(COCOA)
> >      graphicsContext.translate(0, totalHeight);
> >      graphicsContext.scale(FloatSize(1, -1));
> > +#endif
> 
> Seems bizarre that this is here. The platform layer is responsible for
> abstracting differences like this.

I was surprised as well, I guess this is specific to the printing code in mac. 

> > Source/WebCore/page/PrintContext.cpp:357
> > +#if PLATFORM(COCOA)
> > +            int boundaryLineY = currentHeight;
> > +#else
> > +            int boundaryLineY = currentHeight - 1;
> > +#endif
> 
> Same comment about the platform layer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150916/afb1e08b/attachment.html>