<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - printing does not use minimum page zoom factor"
href="https://bugs.webkit.org/show_bug.cgi?id=108507">bug 108507</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=108507#c6">comment #6</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=260361&action=diff" name="attach_260361" title="Try to fix CG build">attachment 260361</a> <a href="attachment.cgi?id=260361&action=edit" title="Try to fix CG build">[details]</a></span>
> Try to fix CG build
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=260361&action=review">https://bugs.webkit.org/attachment.cgi?id=260361&action=review</a>
>
> Looks OK to me.</span >
Thanks for the review.
<span class="quote">> > Source/WebCore/page/PrintContext.cpp:320
> > +int PrintContext::numberOfPages(Frame* frame, const FloatSize& pageSizeInPixels)
>
> Should take a Frame&. The caller is the one that checks for null.</span >
Will change that and the all the callers.
<span class="quote">> > Source/WebCore/page/PrintContext.cpp:329
> > +void PrintContext::spoolAllPagesWithBoundaries(Frame* frame, GraphicsContext& graphicsContext, const FloatSize& pageSizeInPixels)
>
> Should take a Frame&. The caller is the one that checks for null.</span >
Same here.
<span class="quote">> > Source/WebCore/page/PrintContext.cpp:347
> > +#if PLATFORM(COCOA)
> > graphicsContext.translate(0, totalHeight);
> > graphicsContext.scale(FloatSize(1, -1));
> > +#endif
>
> Seems bizarre that this is here. The platform layer is responsible for
> abstracting differences like this.</span >
I was surprised as well, I guess this is specific to the printing code in mac.
<span class="quote">> > Source/WebCore/page/PrintContext.cpp:357
> > +#if PLATFORM(COCOA)
> > + int boundaryLineY = currentHeight;
> > +#else
> > + int boundaryLineY = currentHeight - 1;
> > +#endif
>
> Same comment about the platform layer.</span ></pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>