[Webkit-unassigned] [Bug 148945] Implement the arithmetic instructions for doubles in WebAssembly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 10:52:47 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=148945

--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 260994
  --> https://bugs.webkit.org/attachment.cgi?id=260994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260994&action=review

> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:77
> +// On Windows we need to wrap fmod; on other platforms we can call it directly.
> +// On ARMv7 we assert that all function pointers have to low bit set (point to thumb code).
> +#if CALLING_CONVENTION_IS_STDCALL || CPU(ARM_THUMB2)
> +static double JIT_OPERATION operationFmod(double x, double y)

to low bit => the low bit

I don't understand this comment. Why do we need to wrap fmod on Windows? Your comment says that we need to wrap fmod on Windows and not other platforms, but your code tests for all stdcall and/or thumb2 platforms. Why is it relevant that ARMv7 code is thumb code?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150911/dcce62ff/attachment.html>


More information about the webkit-unassigned mailing list