<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the arithmetic instructions for doubles in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148945#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the arithmetic instructions for doubles in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148945">bug 148945</a>
from <span class="vcard"><a class="email" href="mailto:ggaren@apple.com" title="Geoffrey Garen <ggaren@apple.com>"> <span class="fn">Geoffrey Garen</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260994&action=diff" name="attach_260994" title="Patch">attachment 260994</a> <a href="attachment.cgi?id=260994&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260994&action=review">https://bugs.webkit.org/attachment.cgi?id=260994&action=review</a>
<span class="quote">> Source/JavaScriptCore/wasm/WASMFunctionCompiler.h:77
> +// On Windows we need to wrap fmod; on other platforms we can call it directly.
> +// On ARMv7 we assert that all function pointers have to low bit set (point to thumb code).
> +#if CALLING_CONVENTION_IS_STDCALL || CPU(ARM_THUMB2)
> +static double JIT_OPERATION operationFmod(double x, double y)</span >
to low bit => the low bit
I don't understand this comment. Why do we need to wrap fmod on Windows? Your comment says that we need to wrap fmod on Windows and not other platforms, but your code tests for all stdcall and/or thumb2 platforms. Why is it relevant that ARMv7 code is thumb code?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>