[Webkit-unassigned] [Bug 146012] AX: ARIA 1.1 @aria-current

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 09:38:55 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146012

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 260897
  --> https://bugs.webkit.org/attachment.cgi?id=260897
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260897&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1830
> +    String falseValue = ASCIILiteral("false");
> +    String pageValue = ASCIILiteral("page");
> +    String stepValue = ASCIILiteral("step");
> +    String locationValue = ASCIILiteral("location");
> +    String dateValue = ASCIILiteral("date");
> +    String timeValue = ASCIILiteral("time");

Putting these into local String variables is not helpful. We actually miss the opportunity to get the optimized version of == and waste time every time this function is called, allocating and deallocating 6 extra strings. I suggest just comparing directly with the string literals, or using locals of type const char[] or const char*.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150911/431b57af/attachment.html>


More information about the webkit-unassigned mailing list