<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 @aria-current"
href="https://bugs.webkit.org/show_bug.cgi?id=146012#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 @aria-current"
href="https://bugs.webkit.org/show_bug.cgi?id=146012">bug 146012</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=260897&action=diff" name="attach_260897" title="patch">attachment 260897</a> <a href="attachment.cgi?id=260897&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260897&action=review">https://bugs.webkit.org/attachment.cgi?id=260897&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.cpp:1830
> + String falseValue = ASCIILiteral("false");
> + String pageValue = ASCIILiteral("page");
> + String stepValue = ASCIILiteral("step");
> + String locationValue = ASCIILiteral("location");
> + String dateValue = ASCIILiteral("date");
> + String timeValue = ASCIILiteral("time");</span >
Putting these into local String variables is not helpful. We actually miss the opportunity to get the optimized version of == and waste time every time this function is called, allocating and deallocating 6 extra strings. I suggest just comparing directly with the string literals, or using locals of type const char[] or const char*.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>