[Webkit-unassigned] [Bug 149036] Split FontDescription into lower and higher level types

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149036

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #261002|review?                     |review+
              Flags|                            |

--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 261002
  --> https://bugs.webkit.org/attachment.cgi?id=261002
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=261002&action=review

A bit of a shame that the more commonly used class is the one that has a longer name now.

> Source/WebCore/platform/graphics/FontDescription.h:41
>  class FontDescription {

Seems like this class is almost a struct.

> Source/WebCore/platform/graphics/FontDescription.h:50
> +    int computedPixelSize() const { return int(m_computedSize + 0.5f); }

Not new: This is a strange way to write rounding code.

> Source/WebCore/platform/graphics/FontDescription.h:66
> +    void setComputedSize(float s) { m_computedSize = clampToFloat(s); }

Maybe not new: I don’t understand why it’s valuable to call clampToFloat on a float.

> Source/WebCore/platform/graphics/FontDescription.h:82
> +    FontTraitsMask traitsMask() const;
> +private:

Normally we leave a blank line before "private".

> Source/WebCore/rendering/RenderFullScreen.cpp:88
> +    fullscreenStyle.get().setFontDescription(FontCascadeDescription());

Might want to use { } here so we don’t have to state the type explicitly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150911/7cf02bc0/attachment-0001.html>