<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Split FontDescription into lower and higher level types"
href="https://bugs.webkit.org/show_bug.cgi?id=149036">bug 149036</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #261002 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Split FontDescription into lower and higher level types"
href="https://bugs.webkit.org/show_bug.cgi?id=149036#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Split FontDescription into lower and higher level types"
href="https://bugs.webkit.org/show_bug.cgi?id=149036">bug 149036</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=261002&action=diff" name="attach_261002" title="patch">attachment 261002</a> <a href="attachment.cgi?id=261002&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=261002&action=review">https://bugs.webkit.org/attachment.cgi?id=261002&action=review</a>
A bit of a shame that the more commonly used class is the one that has a longer name now.
<span class="quote">> Source/WebCore/platform/graphics/FontDescription.h:41
> class FontDescription {</span >
Seems like this class is almost a struct.
<span class="quote">> Source/WebCore/platform/graphics/FontDescription.h:50
> + int computedPixelSize() const { return int(m_computedSize + 0.5f); }</span >
Not new: This is a strange way to write rounding code.
<span class="quote">> Source/WebCore/platform/graphics/FontDescription.h:66
> + void setComputedSize(float s) { m_computedSize = clampToFloat(s); }</span >
Maybe not new: I don’t understand why it’s valuable to call clampToFloat on a float.
<span class="quote">> Source/WebCore/platform/graphics/FontDescription.h:82
> + FontTraitsMask traitsMask() const;
> +private:</span >
Normally we leave a blank line before "private".
<span class="quote">> Source/WebCore/rendering/RenderFullScreen.cpp:88
> + fullscreenStyle.get().setFontDescription(FontCascadeDescription());</span >
Might want to use { } here so we don’t have to state the type explicitly.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>