[Webkit-unassigned] [Bug 148439] cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 11 09:06:47 PDT 2015


--- Comment #24 from Darin Adler <darin at apple.com> ---
Comment on attachment 260648
  --> https://bugs.webkit.org/attachment.cgi?id=260648

View in context: https://bugs.webkit.org/attachment.cgi?id=260648&action=review

> Source/WTF/wtf/OSRandomSource.cpp:47
> +#if OS(DARWIN)
> +typedef struct __CCRandom* CCRandomRef;
> +extern const CCRandomRef kCCRandomDefault;
> +extern "C" int CCRandomCopyBytes(CCRandomRef rnd, void *bytes, size_t count);
> +#endif

This is not the correct idiom for new uses of SPI in WebKit. See examples like WTF/wtf/spi/darwin/XPCSPI.h and WTF/wtf/spi/cocoa/NSMapTableSPI.h for the way we now do it.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150911/a458fdd7/attachment.html>

More information about the webkit-unassigned mailing list