<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - cryptographicallyRandomValuesFromOS should use CCRandomCopyBytes when available."
href="https://bugs.webkit.org/show_bug.cgi?id=148439">bug 148439</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260648&action=diff" name="attach_260648" title="Patch">attachment 260648</a> <a href="attachment.cgi?id=260648&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260648&action=review">https://bugs.webkit.org/attachment.cgi?id=260648&action=review</a>
<span class="quote">> Source/WTF/wtf/OSRandomSource.cpp:47
> +#if OS(DARWIN)
> +typedef struct __CCRandom* CCRandomRef;
> +extern const CCRandomRef kCCRandomDefault;
> +extern "C" int CCRandomCopyBytes(CCRandomRef rnd, void *bytes, size_t count);
> +#endif</span >
This is not the correct idiom for new uses of SPI in WebKit. See examples like WTF/wtf/spi/darwin/XPCSPI.h and WTF/wtf/spi/cocoa/NSMapTableSPI.h for the way we now do it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>