[Webkit-unassigned] [Bug 146012] AX: ARIA 1.1 @aria-current

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146012

--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 260310
  --> https://bugs.webkit.org/attachment.cgi?id=260310
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260310&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Updated inspector to support aria-current.

we  should add a WebINspector layout test for these changes too

> Source/WebCore/accessibility/AccessibilityObject.cpp:1834
> +    String currentStateValue = stripLeadingAndTrailingHTMLSpaces(getAttribute(aria_currentAttr));

we should have a unit test within our test that confirms extra white space is removed correctly

thinks also like

"   page "

> Source/WebCore/accessibility/AccessibilityObject.h:439
> +enum AccessibilityCurrentState { CurrentFalse, CurrentTrue, CurrentPage, CurrentStep, CurrentLocation, CurrentDate, CurrentTime };

I think "current" by itself is too vague to be shortened on its own. Maybe we should either call this

ARIACurrent or
ContainerCurrentItem

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2884
> +        switch (currentState) {

we can make this switch (m_object->currentState()) {

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:352
> +                if (accessibilityProperties.current === DOMAgent.AccessibilityPropertiesCurrent.True)

seems like we should use a switch statement here

> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:353
> +                    current = WebInspector.UIString("Yes");

i think this should be "True" instead of Yes, because this is not a binary (yes/no) property but rather a multi-value thing where "true" is different from 'yes"

> LayoutTests/ChangeLog:8
> +        * accessibility/aria-current-expected.txt: Added.

you probably need to add Skip to other TestExpectations and make bugs for Win and GTK to add support to query for aria-current

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150909/91268753/attachment-0001.html>