<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 @aria-current"
href="https://bugs.webkit.org/show_bug.cgi?id=146012#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: ARIA 1.1 @aria-current"
href="https://bugs.webkit.org/show_bug.cgi?id=146012">bug 146012</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260310&action=diff" name="attach_260310" title="patch">attachment 260310</a> <a href="attachment.cgi?id=260310&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260310&action=review">https://bugs.webkit.org/attachment.cgi?id=260310&action=review</a>
<span class="quote">> Source/JavaScriptCore/ChangeLog:8
> + Updated inspector to support aria-current.</span >
we should add a WebINspector layout test for these changes too
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.cpp:1834
> + String currentStateValue = stripLeadingAndTrailingHTMLSpaces(getAttribute(aria_currentAttr));</span >
we should have a unit test within our test that confirms extra white space is removed correctly
thinks also like
" page "
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.h:439
> +enum AccessibilityCurrentState { CurrentFalse, CurrentTrue, CurrentPage, CurrentStep, CurrentLocation, CurrentDate, CurrentTime };</span >
I think "current" by itself is too vague to be shortened on its own. Maybe we should either call this
ARIACurrent or
ContainerCurrentItem
<span class="quote">> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2884
> + switch (currentState) {</span >
we can make this switch (m_object->currentState()) {
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:352
> + if (accessibilityProperties.current === DOMAgent.AccessibilityPropertiesCurrent.True)</span >
seems like we should use a switch statement here
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:353
> + current = WebInspector.UIString("Yes");</span >
i think this should be "True" instead of Yes, because this is not a binary (yes/no) property but rather a multi-value thing where "true" is different from 'yes"
<span class="quote">> LayoutTests/ChangeLog:8
> + * accessibility/aria-current-expected.txt: Added.</span >
you probably need to add Skip to other TestExpectations and make bugs for Win and GTK to add support to query for aria-current</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>