[Webkit-unassigned] [Bug 148838] Implement the relational instructions in WebAssembly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148838

--- Comment #4 from Sukolsak Sakshuwong <sukolsak at gmail.com> ---
Thanks.

(In reply to comment #2)
> Comment on attachment 260658 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=260658&action=review
> 
> r=me with comment
> 
> > Source/JavaScriptCore/tests/stress/wasm-relational.js:119
> > +var module = loadWebAssembly("wasm-relational.wasm");
> 
> I think it'd be nicer to have a directory in stress called "wasm" that holds
> all the
> wasm binaries were testing. Do we have other tests checked in that follow the
> model in this patch? Maybe it's worth changing those.  

Will do.

> Also, would it be possible to write the tests such that
> we can write all wasm tests in JS, and have the loadWebAssembly do the
> translation on the fly?

(In reply to comment #3)
> Doing the JS =>wasm translation on the fly will make
> converting to newer wasm formats much easier.

We will have to include the source code of pack-asmjs (~3,800 lines) and the asm.js parser that it uses (~2,900 lines.) It's probably not worth the time though, considering that eventually, we will have to implement the text format <https://github.com/WebAssembly/design/blob/master/TextFormat.md>. It will be a better way to write tests, because we will have more control over what pack-asmjs generates. asm.js is only a stopgap until the spec is finalized.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150906/2f6c446c/attachment.html>