<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the relational instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148838#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Implement the relational instructions in WebAssembly"
href="https://bugs.webkit.org/show_bug.cgi?id=148838">bug 148838</a>
from <span class="vcard"><a class="email" href="mailto:sukolsak@gmail.com" title="Sukolsak Sakshuwong <sukolsak@gmail.com>"> <span class="fn">Sukolsak Sakshuwong</span></a>
</span></b>
<pre>Thanks.
(In reply to <a href="show_bug.cgi?id=148838#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=260658&action=diff" name="attach_260658" title="Patch">attachment 260658</a> <a href="attachment.cgi?id=260658&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=260658&action=review">https://bugs.webkit.org/attachment.cgi?id=260658&action=review</a>
>
> r=me with comment
>
> > Source/JavaScriptCore/tests/stress/wasm-relational.js:119
> > +var module = loadWebAssembly("wasm-relational.wasm");
>
> I think it'd be nicer to have a directory in stress called "wasm" that holds
> all the
> wasm binaries were testing. Do we have other tests checked in that follow the
> model in this patch? Maybe it's worth changing those. </span >
Will do.
<span class="quote">> Also, would it be possible to write the tests such that
> we can write all wasm tests in JS, and have the loadWebAssembly do the
> translation on the fly?</span >
(In reply to <a href="show_bug.cgi?id=148838#c3">comment #3</a>)
<span class="quote">> Doing the JS =>wasm translation on the fly will make
> converting to newer wasm formats much easier.</span >
We will have to include the source code of pack-asmjs (~3,800 lines) and the asm.js parser that it uses (~2,900 lines.) It's probably not worth the time though, considering that eventually, we will have to implement the text format <<a href="https://github.com/WebAssembly/design/blob/master/TextFormat.md">https://github.com/WebAssembly/design/blob/master/TextFormat.md</a>>. It will be a better way to write tests, because we will have more control over what pack-asmjs generates. asm.js is only a stopgap until the spec is finalized.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>