[Webkit-unassigned] [Bug 148810] Set default encoding of document to be 'UTF-8'.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148810

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260607|review?, commit-queue?      |review-, commit-queue-
              Flags|                            |

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 260607
  --> https://bugs.webkit.org/attachment.cgi?id=260607
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260607&action=review

> Source/WebCore/ChangeLog:11
> +

Please indicate in the Change Log that this behavior is consistent with Firefox.

> Source/WebCore/dom/Document.cpp:-1255
> -    return String();

We should also update Document.idl to drop the [TreatReturnedNullStringAs=Null] IDL extended attribute from the following attributes: inputEncoding, charset, characterSet. The spec says that these attributes are not nullable and we no longer return a null string.

> Source/WebCore/dom/Document.cpp:1255
> +    return String(UTF8Encoding().domName());

I don't believe we need the String()

> LayoutTests/ChangeLog:3
> +        Update the tests which test the default encoding of document.

Please use bug title here: "Set 'UTF-8' to be the default of document encoding." and move "Update the tests which test the default encoding of document." to the description under the Reviewed By line.

> LayoutTests/fast/dom/document-attribute-js-null-expected.txt:5
> +TEST FAILED: The value should have been undefined but was the string 'UTF-8'. [tested Document.charset]

You need to update this test instead of simply rebaselining it. This is not an imported test.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/a0c77219/attachment-0001.html>