<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Set default encoding of document to be 'UTF-8'."
href="https://bugs.webkit.org/show_bug.cgi?id=148810">bug 148810</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260607 Flags</td>
<td>review?, commit-queue?
</td>
<td>review-, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Set default encoding of document to be 'UTF-8'."
href="https://bugs.webkit.org/show_bug.cgi?id=148810#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Set default encoding of document to be 'UTF-8'."
href="https://bugs.webkit.org/show_bug.cgi?id=148810">bug 148810</a>
from <span class="vcard"><a class="email" href="mailto:cdumez@apple.com" title="Chris Dumez <cdumez@apple.com>"> <span class="fn">Chris Dumez</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260607&action=diff" name="attach_260607" title="Patch">attachment 260607</a> <a href="attachment.cgi?id=260607&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260607&action=review">https://bugs.webkit.org/attachment.cgi?id=260607&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:11
> +</span >
Please indicate in the Change Log that this behavior is consistent with Firefox.
<span class="quote">> Source/WebCore/dom/Document.cpp:-1255
> - return String();</span >
We should also update Document.idl to drop the [TreatReturnedNullStringAs=Null] IDL extended attribute from the following attributes: inputEncoding, charset, characterSet. The spec says that these attributes are not nullable and we no longer return a null string.
<span class="quote">> Source/WebCore/dom/Document.cpp:1255
> + return String(UTF8Encoding().domName());</span >
I don't believe we need the String()
<span class="quote">> LayoutTests/ChangeLog:3
> + Update the tests which test the default encoding of document.</span >
Please use bug title here: "Set 'UTF-8' to be the default of document encoding." and move "Update the tests which test the default encoding of document." to the description under the Reviewed By line.
<span class="quote">> LayoutTests/fast/dom/document-attribute-js-null-expected.txt:5
> +TEST FAILED: The value should have been undefined but was the string 'UTF-8'. [tested Document.charset]</span >
You need to update this test instead of simply rebaselining it. This is not an imported test.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>