[Webkit-unassigned] [Bug 148758] Need to be able to test default behaviors on force click

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 11:31:50 PDT 2015


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #260600|review?                     |review+
              Flags|                            |

--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 260600
  --> https://bugs.webkit.org/attachment.cgi?id=260600

View in context: https://bugs.webkit.org/attachment.cgi?id=260600&action=review

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:95
> +    _eventSender_momentumPhase = 0;

No need for this since it's ObjC

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:376
> +static void spinRunLoopForForce()

handleNextPressureEvent() or something! we're not spinning (just handling the next enqueued pressure event), and we should probably be explicit about which event type we're handling.

Actually, since you always -_postDelayed and then spinRunLoopForForce(), you could make it handleForceEventSynchronously(NSEvent *) and do both things inside here! and that will make the other code less repeaty

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150904/0cec6f9c/attachment-0001.html>

More information about the webkit-unassigned mailing list