<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Need to be able to test default behaviors on force click"
href="https://bugs.webkit.org/show_bug.cgi?id=148758">bug 148758</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260600 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Need to be able to test default behaviors on force click"
href="https://bugs.webkit.org/show_bug.cgi?id=148758#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Need to be able to test default behaviors on force click"
href="https://bugs.webkit.org/show_bug.cgi?id=148758">bug 148758</a>
from <span class="vcard"><a class="email" href="mailto:thorton@apple.com" title="Tim Horton <thorton@apple.com>"> <span class="fn">Tim Horton</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260600&action=diff" name="attach_260600" title="Patch">attachment 260600</a> <a href="attachment.cgi?id=260600&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260600&action=review">https://bugs.webkit.org/attachment.cgi?id=260600&action=review</a>
<span class="quote">> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:95
> + _eventSender_momentumPhase = 0;</span >
No need for this since it's ObjC
<span class="quote">> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:376
> +static void spinRunLoopForForce()</span >
handleNextPressureEvent() or something! we're not spinning (just handling the next enqueued pressure event), and we should probably be explicit about which event type we're handling.
Actually, since you always -_postDelayed and then spinRunLoopForForce(), you could make it handleForceEventSynchronously(NSEvent *) and do both things inside here! and that will make the other code less repeaty</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>