[Webkit-unassigned] [Bug 144560] [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144560

--- Comment #24 from Philip Chimento <philip.chimento at gmail.com> ---
(In reply to comment #21)
> > Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp:61
> > -#if OS(DARWIN)
> > +#if PLATFORM(COCOA)
> 
> This doesn’t seem quite right to me, but I can’t come up with anything
> better. PLATFORM(COCOA) is a really high level concept and it not the right
> conditional for “use Mach directly”.
> 
> > Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h:64
> > +#if PLATFORM(COCOA)
> 
> Ditto.

How about OS(DARWIN) && !PLATFORM(GTK) for now? Maybe this should eventually be transformed into USE(MACH) or some such macro. I looked through wtf/Platform.h but didn't see anything appropriate that already exists.

(In reply to comment #22)
> Philip, just in case you haven't figured this out yet: we use r+ cq- to
> indicate the patch is accepted conditional on minor changes, no further
> review required.

Thank you for setting me straight! Indeed I had not figured that out. I've uploaded another patch with the modifications, but I haven't built it yet, so won't mark it cq? until I've done so later today.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151031/295a3e56/attachment.html>