<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560#c24">Comment # 24</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560">bug 144560</a>
from <span class="vcard"><a class="email" href="mailto:philip.chimento@gmail.com" title="Philip Chimento <philip.chimento@gmail.com>"> <span class="fn">Philip Chimento</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144560#c21">comment #21</a>)
<span class="quote">> > Source/WebKit2/UIProcess/Launcher/ProcessLauncher.cpp:61
> > -#if OS(DARWIN)
> > +#if PLATFORM(COCOA)
>
> This doesn’t seem quite right to me, but I can’t come up with anything
> better. PLATFORM(COCOA) is a really high level concept and it not the right
> conditional for “use Mach directly”.
>
> > Source/WebKit2/UIProcess/Launcher/ProcessLauncher.h:64
> > +#if PLATFORM(COCOA)
>
> Ditto.</span >
How about OS(DARWIN) && !PLATFORM(GTK) for now? Maybe this should eventually be transformed into USE(MACH) or some such macro. I looked through wtf/Platform.h but didn't see anything appropriate that already exists.
(In reply to <a href="show_bug.cgi?id=144560#c22">comment #22</a>)
<span class="quote">> Philip, just in case you haven't figured this out yet: we use r+ cq- to
> indicate the patch is accepted conditional on minor changes, no further
> review required.</span >
Thank you for setting me straight! Indeed I had not figured that out. I've uploaded another patch with the modifications, but I haven't built it yet, so won't mark it cq? until I've done so later today.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>