[Webkit-unassigned] [Bug 138566] AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138566

--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 264430
  --> https://bugs.webkit.org/attachment.cgi?id=264430
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264430&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:199
> +    if (!visibleNodes.isEmpty()) {

we should write this as
if (visibleNodes.isEmpty())
   return;

early returns are preferred

> Source/WebCore/accessibility/AXObjectCache.cpp:200
> +        // If any of the node is keyboard focused, we want to pick that.

If any of the nodes "are" keyboard focused

> Source/WebCore/accessibility/AXObjectCache.cpp:227
> +    if (equalIgnoringCase(downcast<Element>(*node).fastGetAttribute(aria_hiddenAttr), "true"))

we might want to use isNodeAriaVisible() here

> Source/WebCore/accessibility/AccessibilityObject.cpp:1857
> +    for (Node* node = this->node(); node; node = node->parentNode()) {

there might be some ancestorsOfKind method that is better here

> Source/WebCore/accessibility/AccessibilityObject.cpp:1864
> +bool AccessibilityObject::shouldIgnoreWhenAriaModalOn() const

I think we should name this method ignoredFromARIAModalPresence()
that's not much better than your name -- i just don't like the "aria modal on" formulation which is a bit weird since aria modal isn't something that gets turned on...

> LayoutTests/accessibility/aria-modal-multiple-dialogs.html:81
> +		dialog.style.display = 'block';

these test files have tabs in them, you should change to spaces

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151031/0a8ccc30/attachment.html>