<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - AX: Add support for ARIA 1.1 attribute 'aria-modal' for dialog and alertdialog"
href="https://bugs.webkit.org/show_bug.cgi?id=138566">bug 138566</a>
from <span class="vcard"><a class="email" href="mailto:cfleizach@apple.com" title="chris fleizach <cfleizach@apple.com>"> <span class="fn">chris fleizach</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264430&action=diff" name="attach_264430" title="patch">attachment 264430</a> <a href="attachment.cgi?id=264430&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264430&action=review">https://bugs.webkit.org/attachment.cgi?id=264430&action=review</a>
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:199
> + if (!visibleNodes.isEmpty()) {</span >
we should write this as
if (visibleNodes.isEmpty())
return;
early returns are preferred
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:200
> + // If any of the node is keyboard focused, we want to pick that.</span >
If any of the nodes "are" keyboard focused
<span class="quote">> Source/WebCore/accessibility/AXObjectCache.cpp:227
> + if (equalIgnoringCase(downcast<Element>(*node).fastGetAttribute(aria_hiddenAttr), "true"))</span >
we might want to use isNodeAriaVisible() here
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.cpp:1857
> + for (Node* node = this->node(); node; node = node->parentNode()) {</span >
there might be some ancestorsOfKind method that is better here
<span class="quote">> Source/WebCore/accessibility/AccessibilityObject.cpp:1864
> +bool AccessibilityObject::shouldIgnoreWhenAriaModalOn() const</span >
I think we should name this method ignoredFromARIAModalPresence()
that's not much better than your name -- i just don't like the "aria modal on" formulation which is a bit weird since aria modal isn't something that gets turned on...
<span class="quote">> LayoutTests/accessibility/aria-modal-multiple-dialogs.html:81
> + dialog.style.display = 'block';</span >
these test files have tabs in them, you should change to spaces</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>