[Webkit-unassigned] [Bug 150315] ERROR: Unhandled web process message 'StorageAreaMap:DispatchStorageEvent'

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 01:27:58 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=150315

--- Comment #8 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Yes, I didn't take into account that now we can have session storage maps without a listener when the connection is closed and destroyStorageMap() hasn't been called. We could either simply change the ASSERT to something like 

ASSERT(isSessionStporage() || m_eventListeners.contains(std::make_pair(&connection, storageMapID)));

or add checks to processDidCloseConnection() and applicationWillTerminate() in case of session storage to not call removeListener if the listener is not present. Since HashMap handles the case of removing a non exiting item, I think it's simpler and probably more efficient to change the assert. Although, it's true that it wouldn't catch valid cases of session storage maps that should have a listener at that point. What do you guys think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151021/11133621/attachment-0001.html>


More information about the webkit-unassigned mailing list