[Webkit-unassigned] [Bug 150366] AX: Expose table size and cell indexes on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150366

--- Comment #4 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 263604
  --> https://bugs.webkit.org/attachment.cgi?id=263604
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921
>> +    for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject())
> 
> why the change here

in isDataTable(), it returns false when the element has ARIA role. So aria table will be considered as not a table.

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012
>> +    return rowCount > 0 ? rowCount : 0;
> 
> can we write as
> 
> return table->rowCount() > 0 ? : 0;

Ok.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/9046610f/attachment.html>