[Webkit-unassigned] [Bug 150366] AX: Expose table size and cell indexes on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150366

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 263604
  --> https://bugs.webkit.org/attachment.cgi?id=263604
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=263604&action=review

I'm wondering

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:921
> +    for (parentTable = m_object; parentTable && !parentTable->isTable(); parentTable = parentTable->parentObject())

why the change here

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1012
> +    return rowCount > 0 ? rowCount : 0;

can we write as

return table->rowCount() > 0 ? : 0;

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1024
> +    return colCount > 0 ? colCount : 0;

ditto

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1036
> +    return rowCount > 0 ? rowCount : 0;

ditto

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1048
> +    return colCount > 0 ? colCount : 0;

ditto

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151020/4b455ed5/attachment-0001.html>