[Webkit-unassigned] [Bug 150238] New: Finalize bug 149952 patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150238

            Bug ID: 150238
           Summary: Finalize bug 149952 patch
    Classification: Unclassified
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: youennf at gmail.com

Following on bug 149952, we should fix what Darin mentionned:

> Source/WebCore/bindings/js/JSDOMConstructor.h:32
> +    static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue);

I noticed one tiny mistake that we should return and fix. I don’t think the meaning of JSC::JSValue is clear here without the argument name, prototype.

> Source/WebCore/bindings/js/JSDOMConstructor.h:137
> +template<typename JSClass> void JSDOMConstructor<JSClass>::finishCreation(JSC::VM& vm, JSDOMGlobalObject& globalObject)

In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.

> Source/WebCore/bindings/js/JSDOMConstructor.h:144
> +template<typename JSClass> JSC::ConstructType JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData& constructData)

In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151016/7c28e54a/attachment-0001.html>