<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_NEW "
title="NEW - Finalize bug 149952 patch"
href="https://bugs.webkit.org/show_bug.cgi?id=150238">150238</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>Finalize bug 149952 patch
</td>
</tr>
<tr>
<th>Classification</th>
<td>Unclassified
</td>
</tr>
<tr>
<th>Product</th>
<td>WebKit
</td>
</tr>
<tr>
<th>Version</th>
<td>WebKit Nightly Build
</td>
</tr>
<tr>
<th>Hardware</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>OS</th>
<td>Unspecified
</td>
</tr>
<tr>
<th>Status</th>
<td>NEW
</td>
</tr>
<tr>
<th>Severity</th>
<td>Normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>P2
</td>
</tr>
<tr>
<th>Component</th>
<td>WebCore JavaScript
</td>
</tr>
<tr>
<th>Assignee</th>
<td>webkit-unassigned@lists.webkit.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>youennf@gmail.com
</td>
</tr></table>
<p>
<div>
<pre>Following on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Binding generator should use templated JSXXConstructor"
href="show_bug.cgi?id=149952">bug 149952</a>, we should fix what Darin mentionned:
<span class="quote">> Source/WebCore/bindings/js/JSDOMConstructor.h:32
> + static JSC::Structure* createStructure(JSC::VM&, JSC::JSGlobalObject&, JSC::JSValue);</span >
I noticed one tiny mistake that we should return and fix. I don’t think the meaning of JSC::JSValue is clear here without the argument name, prototype.
<span class="quote">> Source/WebCore/bindings/js/JSDOMConstructor.h:137
> +template<typename JSClass> void JSDOMConstructor<JSClass>::finishCreation(JSC::VM& vm, JSDOMGlobalObject& globalObject)</span >
In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.
<span class="quote">> Source/WebCore/bindings/js/JSDOMConstructor.h:144
> +template<typename JSClass> JSC::ConstructType JSDOMConstructor<JSClass>::getConstructData(JSC::JSCell*, JSC::ConstructData& constructData)</span >
In the final patch you landed this was one of the only function templates without “inline”. Was that intentional? If not, I suggest adding the inline.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>