[Webkit-unassigned] [Bug 150056] run-webkit-tests does not copy all crash logs for layout test failures on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150056

--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 262955
  --> https://bugs.webkit.org/attachment.cgi?id=262955
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262955&action=review

> Tools/Scripts/webkitpy/common/system/crashlogs.py:122
> +            return  basename.endswith(".crash")

Why are there two spaces here?

> Tools/Scripts/webkitpy/common/system/crashlogs.py:146
> +                    if test_name == "":
> +                        test_name = process_name + "-" + str(pid)

This is not great naming - it's not "test name" in this case.

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:310
> +                if not (any(process[0] == test for process in crashed_processes)):

Are the outer parentheses necessary?

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:45
> +(PASS, FAIL, TEXT, IMAGE, IMAGE_PLUS_TEXT, AUDIO, TIMEOUT, CRASH, CRASH_OTHER, SKIP, WONTFIX,

Don't we need to add support for this new result everywhere? Bot watcher's dashboard and flakiness dashboard come to mind first. Maybe EWS too.

But since these crashes are already in a separate section of the JSON, I don't see why we need a new result.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151015/fdf70dd6/attachment.html>