<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - run-webkit-tests does not copy all crash logs for layout test failures on iOS"
href="https://bugs.webkit.org/show_bug.cgi?id=150056">bug 150056</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262955&action=diff" name="attach_262955" title="Proposed patch">attachment 262955</a> <a href="attachment.cgi?id=262955&action=edit" title="Proposed patch">[details]</a></span>
Proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262955&action=review">https://bugs.webkit.org/attachment.cgi?id=262955&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/common/system/crashlogs.py:122
> + return basename.endswith(".crash")</span >
Why are there two spaces here?
<span class="quote">> Tools/Scripts/webkitpy/common/system/crashlogs.py:146
> + if test_name == "":
> + test_name = process_name + "-" + str(pid)</span >
This is not great naming - it's not "test name" in this case.
<span class="quote">> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:310
> + if not (any(process[0] == test for process in crashed_processes)):</span >
Are the outer parentheses necessary?
<span class="quote">> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:45
> +(PASS, FAIL, TEXT, IMAGE, IMAGE_PLUS_TEXT, AUDIO, TIMEOUT, CRASH, CRASH_OTHER, SKIP, WONTFIX,</span >
Don't we need to add support for this new result everywhere? Bot watcher's dashboard and flakiness dashboard come to mind first. Maybe EWS too.
But since these crashes are already in a separate section of the JSON, I don't see why we need a new result.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>