[Webkit-unassigned] [Bug 148388] We should also store the time information for recent searches

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=148388

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262998|review?                     |review+
              Flags|                            |

--- Comment #47 from Darin Adler <darin at apple.com> ---
Comment on attachment 262998
  --> https://bugs.webkit.org/attachment.cgi?id=262998
Revised Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262998&action=review

> Source/WebCore/platform/SearchPopupMenu.h:42
> +    virtual void saveRecentSearches(const AtomicString& name, const Vector<RecentSearch>& searchItems) = 0;

No need for the second argument to have a name; searchItems is redundant with the type Vector<RecentSearch>.

> Source/WebCore/platform/SearchPopupMenu.h:43
> +    virtual void loadRecentSearches(const AtomicString& name, Vector<RecentSearch>& searchItems) = 0;

No need for the second argument to have a name; searchItems is redundant with the type Vector<RecentSearch>.

We should come back and change this function to use a return value instead of an out argument in a later patch.

> Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:87
> +        for (auto searchItem : searchItems)

This should be auto& rather than auto, since we have no need to copy each searchItem as we iterate the vector.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151014/e7de06d4/attachment-0001.html>