<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388">bug 148388</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262998 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388#c47">Comment # 47</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - We should also store the time information for recent searches"
href="https://bugs.webkit.org/show_bug.cgi?id=148388">bug 148388</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262998&action=diff" name="attach_262998" title="Revised Patch">attachment 262998</a> <a href="attachment.cgi?id=262998&action=edit" title="Revised Patch">[details]</a></span>
Revised Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262998&action=review">https://bugs.webkit.org/attachment.cgi?id=262998&action=review</a>
<span class="quote">> Source/WebCore/platform/SearchPopupMenu.h:42
> + virtual void saveRecentSearches(const AtomicString& name, const Vector<RecentSearch>& searchItems) = 0;</span >
No need for the second argument to have a name; searchItems is redundant with the type Vector<RecentSearch>.
<span class="quote">> Source/WebCore/platform/SearchPopupMenu.h:43
> + virtual void loadRecentSearches(const AtomicString& name, Vector<RecentSearch>& searchItems) = 0;</span >
No need for the second argument to have a name; searchItems is redundant with the type Vector<RecentSearch>.
We should come back and change this function to use a return value instead of an out argument in a later patch.
<span class="quote">> Source/WebCore/platform/cocoa/SearchPopupMenuCocoa.mm:87
> + for (auto searchItem : searchItems)</span >
This should be auto& rather than auto, since we have no need to copy each searchItem as we iterate the vector.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>