[Webkit-unassigned] [Bug 149505] Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149505

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262733|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #21 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 262733
  --> https://bugs.webkit.org/attachment.cgi?id=262733
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262733&action=review

r=me.

> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:77
> +            this.element.classList.add(className);

This statement looks redundant, as it was already one above on line 36.

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-60
> -        this._searchBar = new WebInspector.SearchBar("log-search-bar", WebInspector.UIString("Filter Console Log"), this);

You have removed the only use of "log-search-bar". You should remove the CSS that is no longer used:

Views/LogContentView.css
188:.search-bar.log-search-bar > input[type="search"] {

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:874
> +    _performSearch(searchTerms)

Nit: A pre-existing bug is that the search should re-run when the filter bar changes (All | Errors | Warnings | Logs). That can be filed and fixed separately though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151014/92c6250e/attachment.html>