<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
href="https://bugs.webkit.org/show_bug.cgi?id=149505">bug 149505</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262733 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
href="https://bugs.webkit.org/show_bug.cgi?id=149505#c21">Comment # 21</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner"
href="https://bugs.webkit.org/show_bug.cgi?id=149505">bug 149505</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262733&action=diff" name="attach_262733" title="patch">attachment 262733</a> <a href="attachment.cgi?id=262733&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262733&action=review">https://bugs.webkit.org/attachment.cgi?id=262733&action=review</a>
r=me.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:77
> + this.element.classList.add(className);</span >
This statement looks redundant, as it was already one above on line 36.
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:-60
> - this._searchBar = new WebInspector.SearchBar("log-search-bar", WebInspector.UIString("Filter Console Log"), this);</span >
You have removed the only use of "log-search-bar". You should remove the CSS that is no longer used:
Views/LogContentView.css
188:.search-bar.log-search-bar > input[type="search"] {
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:874
> + _performSearch(searchTerms)</span >
Nit: A pre-existing bug is that the search should re-run when the filter bar changes (All | Errors | Warnings | Logs). That can be filed and fixed separately though.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>