[Webkit-unassigned] [Bug 149968] Web pages with unscalable viewports shouldn't have a single tap delay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149968

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262864|review?                     |review-
              Flags|                            |

--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 262864
  --> https://bugs.webkit.org/attachment.cgi?id=262864
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262864&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2266
> +- (void)_setDoubleTapGesturesEnabled:(BOOL)enabled
> +{
> +    if (enabled && ![_doubleTapGestureRecognizer isEnabled]) {
> +        // The first tap recognized after re-enabling double tap gestures will not wait for the
> +        // second tap before committing. To fix this, we use a new double tap gesture recognizer.
> +        [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
> +        [_doubleTapGestureRecognizer setDelegate:nil];
> +        [self _createAndConfigureDoubleTapGestureRecognizer];
> +    }
> +    [_doubleTapGestureRecognizer setEnabled:enabled];
> +}

Why can't we do this when we adjust the UIScrollView zoom scales? We know if it's zoomable there.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:252
> +    bool viewportIsUserScalable = userCanScaleViewport(m_viewportConfiguration);
> +    if (viewportWasUserScalable != viewportIsUserScalable)
> +        send(Messages::WebPageProxy::ViewportUserScalableDidChange(viewportIsUserScalable));

This should not be a new message (if it's needed at all); it should be in the transaction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151012/b7ea3929/attachment.html>