<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web pages with unscalable viewports shouldn't have a single tap delay"
href="https://bugs.webkit.org/show_bug.cgi?id=149968">bug 149968</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262864 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web pages with unscalable viewports shouldn't have a single tap delay"
href="https://bugs.webkit.org/show_bug.cgi?id=149968#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web pages with unscalable viewports shouldn't have a single tap delay"
href="https://bugs.webkit.org/show_bug.cgi?id=149968">bug 149968</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262864&action=diff" name="attach_262864" title="Patch">attachment 262864</a> <a href="attachment.cgi?id=262864&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262864&action=review">https://bugs.webkit.org/attachment.cgi?id=262864&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2266
> +- (void)_setDoubleTapGesturesEnabled:(BOOL)enabled
> +{
> + if (enabled && ![_doubleTapGestureRecognizer isEnabled]) {
> + // The first tap recognized after re-enabling double tap gestures will not wait for the
> + // second tap before committing. To fix this, we use a new double tap gesture recognizer.
> + [self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
> + [_doubleTapGestureRecognizer setDelegate:nil];
> + [self _createAndConfigureDoubleTapGestureRecognizer];
> + }
> + [_doubleTapGestureRecognizer setEnabled:enabled];
> +}</span >
Why can't we do this when we adjust the UIScrollView zoom scales? We know if it's zoomable there.
<span class="quote">> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:252
> + bool viewportIsUserScalable = userCanScaleViewport(m_viewportConfiguration);
> + if (viewportWasUserScalable != viewportIsUserScalable)
> + send(Messages::WebPageProxy::ViewportUserScalableDidChange(viewportIsUserScalable));</span >
This should not be a new message (if it's needed at all); it should be in the transaction.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>